Crypto options were limited to a hard-coded asset list, with one address per coin in a side table. A payout address now carries everything an invoice needs: ticker, name, QR URI scheme, amount parameter, CoinGecko id, address and an active flag. Any coin can be added, several addresses per ticker are fine, and known tickers fill the QR and rate fields from the built-in templates. The new-invoice form picks a payout address. The invoice snapshots the ticker, address, name, scheme and amount parameter, and the PDF and QR render from that copy, so editing, retiring or deleting a payout entry never changes an issued invoice. "Fetch live" looks up the rate by the payout address's CoinGecko id. Migration 012 keeps the existing rows and backfills both the payout metadata and the snapshots on existing crypto invoices. Assisted-by: Claude:opus-5
160 lines
6 KiB
Ruby
160 lines
6 KiB
Ruby
require_relative 'test_helper'
|
|
|
|
class InvoiceTest < Minitest::Test
|
|
def setup
|
|
skip 'TEST_DATABASE_URL not set' unless TestDb.available?
|
|
TestDb.clean!
|
|
@year = Date.today.year
|
|
end
|
|
|
|
def insert_number(num)
|
|
DB.connection[:invoices].insert(
|
|
uuid: SecureRandom.uuid, number: num, client_name: 'c', client_email: 'c@example.com',
|
|
currency: 'EUR', gel_rate: 3, subtotal: 1,
|
|
items: [{ 'description' => 'x', 'qty' => '1', 'unit_price' => '1' }].to_json,
|
|
issued_on: Date.today, due_on: Date.today + 14, pdf_key: 'k', created_at: Time.now.utc
|
|
)
|
|
end
|
|
|
|
def test_allocate_number_starts_at_one
|
|
assert_equal "INV-#{@year}-0001", Invoice.allocate_number
|
|
end
|
|
|
|
def test_allocate_number_increments
|
|
insert_number("INV-#{@year}-0001")
|
|
insert_number("INV-#{@year}-0002")
|
|
assert_equal "INV-#{@year}-0003", Invoice.allocate_number
|
|
end
|
|
|
|
def test_allocate_number_sorts_numerically_past_9999
|
|
insert_number("INV-#{@year}-9999")
|
|
insert_number("INV-#{@year}-10000")
|
|
assert_equal "INV-#{@year}-10001", Invoice.allocate_number
|
|
end
|
|
|
|
def test_allocate_number_ignores_other_years
|
|
insert_number("INV-#{@year - 1}-0500")
|
|
assert_equal "INV-#{@year}-0001", Invoice.allocate_number
|
|
end
|
|
|
|
def test_duplicate_number_raises_unique_violation
|
|
insert_number("INV-#{@year}-0001")
|
|
assert_raises(Sequel::UniqueConstraintViolation) { insert_number("INV-#{@year}-0001") }
|
|
end
|
|
|
|
def test_build_round_trip
|
|
inv = Invoice.build(
|
|
client_name: 'ACME', client_email: 'billing@example.com', client_address: '',
|
|
currency: 'EUR', gel_rate: '3.05', issued_on: '', due_on: '', notes: '',
|
|
items: [{ 'description' => 'work', 'qty' => '2', 'unit_price' => '100.50' }]
|
|
)
|
|
inv.pdf_key = "invoices/#{inv.number}-#{inv.uuid}.pdf"
|
|
inv.save_changes
|
|
|
|
saved = Invoice[uuid: inv.uuid]
|
|
assert_equal BigDecimal('201'), saved.total
|
|
assert_equal BigDecimal('613.05'), saved.total_gel
|
|
assert_equal 'pending', saved.status
|
|
refute saved.crypto?
|
|
end
|
|
|
|
def test_build_derives_crypto_amount_from_rate
|
|
inv = Invoice.build(
|
|
client_name: 'ACME', client_email: 'billing@example.com',
|
|
currency: 'EUR', gel_rate: '3.05',
|
|
items: [{ 'description' => 'work', 'qty' => '1', 'unit_price' => '100' }],
|
|
crypto_coin: 'ltc', crypto_address: 'ltc1qexampleexampleexampleexample',
|
|
crypto_rate: '80', crypto_amount: ''
|
|
)
|
|
assert inv.crypto?
|
|
assert_equal 'LTC', inv.crypto_coin
|
|
assert_equal BigDecimal('1.25'), inv.crypto_amount_due
|
|
end
|
|
|
|
def test_build_fills_known_ticker_from_template
|
|
inv = Invoice.build(
|
|
client_name: 'ACME', client_email: 'billing@example.com', currency: 'EUR', gel_rate: '3.05',
|
|
items: [{ 'description' => 'work', 'qty' => '1', 'unit_price' => '100' }],
|
|
crypto_coin: 'ltc', crypto_address: 'ltc1qexampleexampleexampleexample'
|
|
)
|
|
assert_equal ['Litecoin', 'litecoin', 'amount'], [inv.crypto_name, inv.crypto_scheme, inv.crypto_amount_param]
|
|
end
|
|
|
|
# Any ticker works once a payout address defines it; the invoice keeps
|
|
# its own copy of the QR metadata.
|
|
def test_build_takes_snapshot_for_custom_coin
|
|
inv = Invoice.build(
|
|
client_name: 'ACME', client_email: 'billing@example.com', currency: 'EUR', gel_rate: '3.05',
|
|
items: [{ 'description' => 'work', 'qty' => '1', 'unit_price' => '100' }],
|
|
crypto_coin: 'DOGE', crypto_address: 'D6examplexampleexampleexample',
|
|
crypto_name: 'Dogecoin', crypto_scheme: 'dogecoin', crypto_amount_param: 'amount'
|
|
)
|
|
assert_equal ['DOGE', 'Dogecoin', 'dogecoin'], [inv.crypto_coin, inv.crypto_name, inv.crypto_scheme]
|
|
end
|
|
|
|
def test_build_rejects_malformed_ticker
|
|
assert_raises(ArgumentError) do
|
|
Invoice.build(client_name: 'A', client_email: 'a@example.com', currency: 'EUR', gel_rate: '3',
|
|
items: [{ 'description' => 'w', 'qty' => '1', 'unit_price' => '1' }],
|
|
crypto_coin: 'bad coin', crypto_address: 'D6examplexampleexampleexample')
|
|
end
|
|
end
|
|
end
|
|
|
|
class InvoiceValidationTest < Minitest::Test
|
|
BASE = {
|
|
client_name: 'ACME', client_email: 'billing@example.com', currency: 'EUR',
|
|
gel_rate: '3.05', payout_id: '', crypto_rate: '', crypto_amount: '',
|
|
items: [{ 'description' => 'work', 'qty' => '1', 'unit_price' => '100' }]
|
|
}.freeze
|
|
|
|
def setup
|
|
skip 'TEST_DATABASE_URL not set' unless TestDb.available?
|
|
@app = AsxpioWeb.new!
|
|
end
|
|
|
|
def validate(over = {})
|
|
@app.send(:validate_invoice_params, BASE.merge(over).dup)
|
|
end
|
|
|
|
def test_valid_params_pass
|
|
assert_empty validate
|
|
end
|
|
|
|
def test_gel_rate_must_be_positive
|
|
assert_includes validate(gel_rate: '0'), :gel_rate
|
|
assert_includes validate(gel_rate: '-2.9'), :gel_rate
|
|
refute_includes validate(gel_rate: '2.95'), :gel_rate
|
|
end
|
|
|
|
def test_item_numbers_must_parse
|
|
assert_includes validate(items: [{ 'description' => 'w', 'qty' => '1,5', 'unit_price' => '100' }]), :items
|
|
assert_includes validate(items: [{ 'description' => 'w', 'qty' => '1', 'unit_price' => 'abc' }]), :items
|
|
end
|
|
|
|
def test_blank_item_numbers_allowed
|
|
assert_empty validate(items: [{ 'description' => 'w', 'qty' => '', 'unit_price' => '' }])
|
|
end
|
|
|
|
def test_at_least_one_item_required
|
|
assert_includes validate(items: [{ 'description' => '', 'qty' => '1', 'unit_price' => '1' }]), :items
|
|
end
|
|
|
|
def test_unknown_or_inactive_payout_rejected
|
|
assert_includes validate(payout_id: '999999'), :payout_id
|
|
p = PayoutAddress.create(coin: 'LTC', name: 'Litecoin', address: 'ltc1qvalidvalidvalidvalid', active: false,
|
|
updated_by: 't', updated_at: Time.now.utc)
|
|
assert_includes validate(payout_id: p.id.to_s), :payout_id
|
|
p.update(active: true)
|
|
assert_empty validate(payout_id: p.id.to_s)
|
|
ensure
|
|
p&.destroy
|
|
end
|
|
|
|
def test_crypto_rate_must_be_positive
|
|
p = PayoutAddress.create(coin: 'LTC', name: 'Litecoin', address: 'ltc1qvalidvalidvalidvalid', updated_by: 't', updated_at: Time.now.utc)
|
|
assert_includes validate(payout_id: p.id.to_s, crypto_rate: '-1'), :crypto_rate
|
|
ensure
|
|
p&.destroy
|
|
end
|
|
end
|